fix: handle settings with missing shared section
#505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows configuration files without a `shared` field, using the
default value if missing.
Before:
$ pueued -vv -c /dev/null
Error: Error while reading configuration.
Caused by:
Error while reading configuration:
missing field `shared`
After:
$ pueued -vv -c /dev/null
21:12:26 [INFO] Restoring state
21:12:26 [INFO] Using unix socket at: "/run/user/1000/pueue_rycee.socket"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #505 +/- ##
============================================
Coverage 80.18% 80.18%
============================================
Files 77 77
Lines 5673 5673
============================================
Hits 4549 4549
Misses 1124 1124 ☔ View full report in Codecov by Sentry. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows configuration files without a
sharedfield, using the default value if missing.Before:
After:
Checklist
CHANGELOG.md.cargo clippyandcargo fmt. The CI will fail otherwise anyway.